Skip to content

Add PassThru parameter to Install, Uninstall and Repair commands#2091

Merged
johlju merged 1 commit intodsccommunity:mainfrom
johlju:fix/fix-passthru
Apr 6, 2025
Merged

Add PassThru parameter to Install, Uninstall and Repair commands#2091
johlju merged 1 commit intodsccommunity:mainfrom
johlju:fix/fix-passthru

Conversation

@johlju
Copy link
Copy Markdown
Member

@johlju johlju commented Apr 6, 2025

Pull Request (PR) description

  • Install-SqlDscReportingService
    • Add PassThru parameter to return exit code.
  • Install-SqlDscBIReportServer
    • Add PassThru parameter to return exit code.
  • Repair-SqlDscReportingService
    • Add PassThru parameter to return exit code.
  • Repair-SqlDscBIReportServer
    • Add PassThru parameter to return exit code.
  • Uninstall-SqlDscReportingService
    • Add PassThru parameter to return exit code.
  • Uninstall-SqlDscBIReportServer
    • Add PassThru parameter to return exit code.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner April 6, 2025 14:19
@johlju johlju added the needs review The pull request needs a code review. label Apr 6, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (37b433c) to head (3967040).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2091   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files       105     105           
  Lines      8100    8114   +14     
====================================
+ Hits       7673    7689   +16     
+ Misses      427     425    -2     
Flag Coverage Δ
unit 94% <100%> (+<1%) ⬆️
Files with missing lines Coverage Δ
source/Private/Invoke-ReportServerSetupAction.ps1 98% <100%> (+2%) ⬆️
source/Public/Install-SqlDscBIReportServer.ps1 100% <100%> (ø)
source/Public/Install-SqlDscReportingService.ps1 100% <100%> (ø)
source/Public/Repair-SqlDscBIReportServer.ps1 100% <100%> (ø)
source/Public/Repair-SqlDscReportingService.ps1 100% <100%> (ø)
source/Public/Uninstall-SqlDscBIReportServer.ps1 100% <100%> (ø)
source/Public/Uninstall-SqlDscReportingService.ps1 100% <100%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit f9eda7b into dsccommunity:main Apr 6, 2025
52 checks passed
@johlju johlju deleted the fix/fix-passthru branch April 6, 2025 18:47
@johlju johlju removed the needs review The pull request needs a code review. label Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant